serialize: Don't save undo stack if saveundo=off #4003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micro always saves the undo stack information into the serialized buffer file as long as either `saveundo` or `savecursor` is enabled. Whereas in the case when only `savecursor` is enabled, while `saveundo` is disabled, this information is not used afterwards, so it only wastes the disk space in `~/.config/micro/buffers`. (And given that currently micro never automatically removes any serialized buffer files, it may significantly contribute to the overall ever growing size of the `~/.config/micro/buffers` directory.) So avoid saving the undo info if `saveundo` is disabled. This makes the size of each serialized buffer file with savecursor=on saveundo=off small and predictable, e.g. around 600 bytes in my observations (whereas without this fix, it may grow indefinitely big, depending on the number of modifications the user made before saving the file).
JoeKar
approved these changes
Feb 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro always saves the undo stack information into the serialized buffer file as long as either
saveundoorsavecursoris enabled. Whereas in the case when onlysavecursoris enabled, whilesaveundois disabled, this information is not used afterwards, so it only wastes the disk space in~/.config/micro/buffers. (And given that currently micro never automatically removes any serialized buffer files, it may significantly contribute to the overall ever growing size of the~/.config/micro/buffersdirectory.)So avoid saving the undo info if
saveundois disabled. This makes the size of each serialized buffer file with savecursor=on saveundo=off small and predictable, e.g. around 600 bytes in my observations (whereas without this fix, it may grow indefinitely big, depending on the number of modifications the user made before saving the file).Context: #3995 (comment)