Forward CMAKE_SYSTEM_NAME to xrceagent cmake #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify backport foxy main |
🟠 Waiting for conditions to match
Hey, I reacted but my real name is @Mergifyio |
|
Nice catch! Will merge once CI passes |
Acuadros95
approved these changes
Jan 12, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
(cherry picked from commit 8aea206)
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
(cherry picked from commit 8aea206)
✅ Backports have been created
|
Acuadros95
pushed a commit
that referenced
this pull request
Jan 12, 2022
Acuadros95
pushed a commit
that referenced
this pull request
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
CMAKE_SYSTEM_NAMEis set to nothing according to the docs. At least on my system (macOS),CMAKE_SYSTEM_NAMEdoes not get set in the CMake file of the xrceagent, hence it's not correctly configured. Forwarding it seems to fix this.