Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#244 add check if startRelative is valid #245

Merged
merged 1 commit into from
Apr 8, 2019
Merged

#244 add check if startRelative is valid #245

merged 1 commit into from
Apr 8, 2019

Conversation

micmro
Copy link
Owner

@micmro micmro commented Apr 5, 2019

else skip and add warning in console

Screen Shot 2019-04-05 at 9 21 35 AM

@micmro
#244 add check if startRelative is valid
aeb2b79 
else skip and add warning in console
@micmro micmro requested a review from soulgalore April 5, 2019 07:22
@micmro micmro mentioned this pull request Apr 5, 2019
Closed
@soulgalore soulgalore merged commit 2661428 into master Apr 8, 2019
@soulgalore soulgalore deleted the 244-handle-invalid-startrelative branch April 8, 2019 11:03
@soulgalore
Copy link
Collaborator

Great thank you @micmro !

@micmro
Copy link
Owner Author

micmro commented Apr 8, 2019

release with v2.5.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulgalore soulgalore Awaiting requested review from soulgalore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micmro @soulgalore