-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight H2 push in the waterfall #198
Comments
See #119 (comment):
|
Options to check if a response was pushed:
Perhaps we can add some more info about the push when hovering over the icon (looks like WPT only)?
For future reference: Another good source for http2 sites would be this httpArchive BigQuery Script |
Yep we should pickup the header too, good idea. I think @tobli added a screenshot somewhere on how we can highlight it in the waterfall. |
Added the screenshot and @tobli's comment as quote to your initial reference. |
The x-http2-push header is in no shape or Form standard. E.g. CDNs such as Cloudflare are using different ones such as cf-h2-pushed. Instead of incorporating this zoo of possibilities we should concentrate on Browser feedback |
I'm aware it's not a standard, but better than nothing. What exactly do you mean with "Browser feedback"? |
Yes think we should add those extra WPT only, we haven't had the chance to add it browsertime but when we do, we can follow the same standard. I think it good for us to catch what we can and then when HAR spec 2.0 comes out we can follow the new standard :D |
I like it (but I'm biased ;-). Good work! |
Thanks. I meant to da that, but have not gotten around to do so :). |
Finally (after a very long time) I got around to work on this issue again. You can checkout branch |
Released via |
@tobli has an idea of how we can show pushes directly inside the waterfall graph. @worenga provided us a couple of H2 push URLs that we can use for testing:
The text was updated successfully, but these errors were encountered: