Skip to content

Minor fix for build-relationships.py #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Conversation

tmcgilchrist
Copy link
Contributor

I discovered this while working on OCaml support for combobulate.

Running the codegen step for OCaml grammars results in invalid syntax for rules in combobulate-rules.el. Some of the rules e.g. _signed_constant don't produce quoted strings.

...
 (_signed_constant (:*unnamed* ("signed_number" "unit" "character" "quoted_string" "string" "number" "boolean"))) 
 (_simple_class_expression (:*unnamed* ("class_path" "typed_class_expression" "parenthesized_class_expression" "extension" "quoted_extension" "object_expression" "instantiated_class"))) 
 ...

Using these versions of the OCaml treesitter grammar:

nodes = https://raw.githubusercontent.com/tree-sitter/tree-sitter-ocaml/v0.24.0/grammars/ocaml/src/node-types.json
grammar = https://raw.githubusercontent.com/tree-sitter/tree-sitter-ocaml/v0.24.0/grammars/ocaml/src/grammar.json

I also needed this same fix for Rust and Haskell grammars.

@mickeynp mickeynp merged commit 19955bc into mickeynp:master Jun 20, 2025
@mickeynp
Copy link
Owner

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants