Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional logging and expose sendbeacon #16

Merged
merged 4 commits into from
Feb 6, 2015
Merged

Conversation

jakiestfu
Copy link
Contributor

This PR focuses on two tasks:

  • Kill logging unless debug: true is specified with the options
  • Return the sendbeacon method so additional custom events may be triggered by the user leveraging the library:
var analytics = player.ga();
analytics.sendbeacon('MyEvent', true, 'foobar');

mickey added a commit that referenced this pull request Feb 6, 2015
Optional logging and expose sendbeacon
@mickey mickey merged commit 9ee5803 into mickey:master Feb 6, 2015
@mickey
Copy link
Owner

mickey commented Feb 6, 2015

Looks good! Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants