Merge pull request AlchemyCMS#1879 from tvdeyen/picture-thumbnail-siz…

…es-constant Extract picture thumbnail sizes in a constant
mickenorlen · Jun 16, 2020 · f637e02 · f637e02
2 parents 2dd2929 + ee69d49
commit f637e02
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -227,7 +227,7 @@ Style/StringLiteralsInInterpolation:
   EnforcedStyle: double_quotes
 
 Style/TrailingCommaInArguments:
-  EnforcedStyleForMultiline: comma
+  Enabled: false
 
 Style/TrailingCommaInArrayLiteral:
   EnforcedStyleForMultiline: comma

diff --git a/app/helpers/alchemy/admin/pictures_helper.rb b/app/helpers/alchemy/admin/pictures_helper.rb
@@ -4,12 +4,10 @@ module Alchemy
   module Admin
     module PicturesHelper
       def preview_size(size)
-        case size
-        when "small" then "80x60"
-        when "large" then "240x180"
-        else
-          "160x120"
-        end
+        Alchemy::Picture::THUMBNAIL_SIZES.fetch(
+          size,
+          Alchemy::Picture::THUMBNAIL_SIZES[:medium]
+        )
       end
     end
   end

diff --git a/app/models/alchemy/picture.rb b/app/models/alchemy/picture.rb
@@ -22,6 +22,12 @@
 
 module Alchemy
   class Picture < BaseRecord
+    THUMBNAIL_SIZES = {
+      small: "80x60",
+      medium: "160x120",
+      large: "240x180",
+    }.with_indifferent_access.freeze
+
     CONVERTIBLE_FILE_FORMATS = %w(gif jpg jpeg png).freeze
 
     include Alchemy::NameConversions