Scope has one site (AlchemyCMS#1832)

* Make alchemy_pages.layoutpage null: false

We want to have an actual Boolean and no nil values.

* Scope Language Root Page to Non-Layoutpages

Layoutpages can not be root pages.

app/models/alchemy/language.rb

@@ -30,7 +30,7 @@ class Language < BaseRecord
 
     before_validation :set_locale, if: -> { locale.blank? }
 
-    has_one :root_page, -> { where(parent: nil) }, class_name: "Alchemy::Page"
+    has_one :root_page, -> { where(parent: nil, layoutpage: false) }, class_name: "Alchemy::Page"
 
     validates :name, presence: true
     validates :page_layout, presence: true

db/migrate/20200514091507_make_page_layoutpage_null_false.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+class MakePageLayoutpageNullFalse < ActiveRecord::Migration[5.2]
+  def change
+    change_column_null :alchemy_pages, :layoutpage, false, false
+  end
+end

spec/dummy/db/migrate/20200514091507_make_page_layoutpage_null_false.rb

@@ -0,0 +1 @@
+../../../../db/migrate/20200514091507_make_page_layoutpage_null_false.rb

spec/dummy/db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_05_05_215518) do
+ActiveRecord::Schema.define(version: 2020_05_14_091507) do
 
   create_table "alchemy_attachments", force: :cascade do |t|
     t.string "name"
@@ -221,7 +221,7 @@
     t.boolean "robot_index", default: true
     t.boolean "robot_follow", default: true
     t.boolean "sitemap", default: true
-    t.boolean "layoutpage", default: false
+    t.boolean "layoutpage", default: false, null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
     t.integer "creator_id"

spec/models/alchemy/page_spec.rb

@@ -61,7 +61,7 @@ module Alchemy
       end
 
       context "a page not being a language_root and without parent" do
-        let(:page) { build(:alchemy_page, parent: nil, layoutpage: nil) }
+        let(:page) { build(:alchemy_page, parent: nil, layoutpage: false) }
 
         it { expect(page).to_not be_valid }
       end
@@ -360,7 +360,7 @@ module Alchemy
       let!(:klingon_lang_root) do
         create :alchemy_page, :language_root, {
           name: "klingon_lang_root",
-          layoutpage: nil,
+          layoutpage: false,
           language: klingon,
         }
       end
@@ -385,10 +385,8 @@ module Alchemy
         expect(Page.contentpages.to_a.select { |p| p.layoutpage == true }).to be_empty
       end
 
-      it "contains pages with attribute :layoutpage set to nil" do
-        expect(Page.contentpages.to_a.select do |page|
-          page.layoutpage.nil?
-        end).to include(klingon_lang_root)
+      it "contains pages with attribute :layoutpage set to false" do
+        expect(Page.contentpages.to_a.select { |p| p.layoutpage == false }).to include(klingon_lang_root)
       end
     end