Explore update button labels (apache#3534)

* resolve ui ambiguity * resolve button name ambiguity * update test
michellethomas · May 23, 2018 · cb447ee · cb447ee
1 parent 88213f9
commit cb447ee
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/superset/assets/javascripts/explore/components/DisplayQueryButton.jsx b/superset/assets/javascripts/explore/components/DisplayQueryButton.jsx
@@ -93,7 +93,7 @@ export default class DisplayQueryButton extends React.PureComponent {
       <ModalTrigger
         animation={this.props.animation}
         isButton
-        triggerNode={<span>Query</span>}
+        triggerNode={<span>View Query</span>}
         modalTitle={t('Query')}
         bsSize="large"
         beforeOpen={this.beforeOpen}

diff --git a/superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx b/superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx
@@ -41,7 +41,7 @@ export default function QueryAndSaveBtns(
       bsStyle={qryButtonStyle}
       disabled={!!errorMessage}
     >
-      <i className="fa fa-bolt" /> Query
+      <i className="fa fa-bolt" /> Run Query
     </Button>
   );
 

diff --git a/superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx b/superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx
@@ -31,7 +31,7 @@ describe('QueryAndSaveButtons', () => {
     });
 
     it('renders buttons with correct text', () => {
-      expect(wrapper.find(Button).contains(' Query')).to.eql(true);
+      expect(wrapper.find(Button).contains(' Run Query')).to.eql(true);
       expect(wrapper.find(Button).contains(' Save')).to.eql(true);
     });