Skip to content

Bugfix CI failing by forcing to retrieve the MKL package from the conda-forge channel #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

Roy-Haolin-Du
Copy link
Contributor

@Roy-Haolin-Du Roy-Haolin-Du commented Mar 30, 2025

Description

  • Our CI tests ran successfully across all Python versions (3.10, 3.11, 3.12) last week. However, this week the same code began failing specifically in Python 3.11 environments, while continuing to pass in 3.10 and 3.12. The failure manifested during the parameterization process where AmberTools' Antechamber component reported it could not find the libmkl_core.so.2 shared library.
  • Resolving this issue with the following modification to our environment file(devtools/conda-envs/test_env.yaml):
dependencies:
  # Other dependencies unchanged
  - conda-forge::mkl>=2022.1.0  # Explicitly specify MKL from conda-forge channel

Close #41.

Status

  • Ready to go
  • Pass all CI test

Could you please review? @fjclark

@fjclark
Copy link
Collaborator

fjclark commented Mar 31, 2025

Perfect, thanks very much for getting to the bottom of this Roy!

Just for my understanding, why is it needed to explicitly specify conda-forge with conda-forge:: e.g. does mkl>=2022.1.0 not work?

@Roy-Haolin-Du
Copy link
Contributor Author

Roy-Haolin-Du commented Mar 31, 2025

Thank you, you’re right.
We've already set conda-forge as the highest priority channel, so specifying mkl >= 2022.1.0 works directly.
The tests have passed as well.
Can I go ahead and merge?
Thanks~

@fjclark
Copy link
Collaborator

fjclark commented Mar 31, 2025

Perfect, thanks Roy!

@fjclark fjclark merged commit 754249c into michellab:main Mar 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Is Failing with Py 3.11 and 3.12 Due to Parameterisation Failure
2 participants