Skip to content

Added composer.json file as described in Issue 31 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

baldurrensch
Copy link

#31

@marijn
Copy link

marijn commented Oct 4, 2012

👍

@michelf
Copy link
Owner

michelf commented Oct 5, 2012

Looks like something that'd fit better with the new lib branch I added today. That branch should conform to PSR-0, assuming I haven't done anything wrong.

@simensen
Copy link
Contributor

This composer.json will not work as it does not specify the autoloader information required to actually use the classes. I believe the following would need to be added in addition to rebasing agains the lib branch in order for the classes to be usable:

"autoload": {
    "psr-0": { "michelf": "" }
},

@michelf I'm super excited you are moving in this direction. There are a lot of people using my port (dflydev/markdown) and I'd be really excited to be able to reference the official php-markdown distribution as an option instead of maintaining my port indefinitely.

I'd be happy to help on any and all fronts with this! Please let me know if you have any questions on Composer, Packagist, or want help maintaining this package on Packagist once you're ready to publish it there.

@ghost
Copy link

ghost commented Oct 22, 2012

@michelf - yes, a PSR-0 version would be better. You can always make it BC by having a markdown.php in the root which require's the other two files.

@simensen
Copy link
Contributor

@michelf How much work have you been abel to do on the lib branch? Are you close to being able to release that?

@michelf
Copy link
Owner

michelf commented Dec 18, 2012

I haven't worked much on it. I plan to finalize, annouce, and release it at the same time the next version comes in... Which should be done in less than a month. Technically, there isn't much left to do. Perhaps only adding the composer file.

@michelf
Copy link
Owner

michelf commented Dec 18, 2012

@Drak Backward compatibility on the PHP API side is of no concern in the lib branch. It's a clean break. That's the whole point.

I still need to be able to merge with the other branches however, until they are deprecated. So this puts limits on code refactorings. But the API is a clean break.

@ghost
Copy link

ghost commented Jan 7, 2013

You know for the php 4 version you can just add a files: require and be done with it.... then worry about the PSR-0 stuff on your lib branch.

"autoload": {
    "files": ["markdown.php"]
}

"name": "John Gruber",
"homepage": "http://daringfireball.net"
}
],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing compatible loader:

"autoload": {
    "files": ["markdown.php"]
}

@jason-gu
Copy link

Please add composer support, thanks

@michelf
Copy link
Owner

michelf commented Jan 13, 2013

This has been merged on the lib branch (as discussed earlier). Note, that as this pull request was made against master, github won't close it automatically and won't show it as merged, so I have to close it manually.

@michelf michelf closed this Jan 13, 2013
@baldurrensch baldurrensch deleted the composer branch January 16, 2013 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants