Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onTouchStart handler to listeners #19

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

sliterok
Copy link
Contributor

Doing my research i found that library works on easypz.io for mobile devices only because of polyfills. Not the case with my app so nothing was listening for touchstart event.

Doing my research i found that library works on easypz.io for mobile devices only because of polyfills. Not the case with my app so nothing was listening for touchstart event.
@sliterok
Copy link
Contributor Author

svg element event listeners on my website:
image
svg element event listeners on easypz.io
image
None of touch actions were working for me. Adding touchstart handler to listeners list has fixed the issue.

@sliterok
Copy link
Contributor Author

If someone need temporarily fix it'll look like:

easypz = new EasyPZ(...)
easypz.removeHostListeners()
easypz.listeners.touchstart = easypz.onTouchStart.bind(easypz)
easypz.setupHostListeners()

michaschwab added a commit that referenced this pull request Nov 3, 2020
@michaschwab michaschwab merged commit 7c529ca into michaschwab:master Nov 3, 2020
@michaschwab
Copy link
Owner

My bad! Thank you for this, looks good! Works again now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants