Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for recalibrated data #15

Open
rickhelmus opened this issue Jun 17, 2022 · 2 comments
Open

Support for recalibrated data #15

rickhelmus opened this issue Jun 17, 2022 · 2 comments

Comments

@rickhelmus
Copy link

Hello,

First of all, many thanks for all the nice work put in this library! :-)

I was wondering if it would be possible to load data that was recalibrated? I noticed a comment it is not, but am curious as to why and if there are any workarounds.

Thanks,
Rick

@rickhelmus
Copy link
Author

So it seems it is possible with the DLL/lib from the latest Bruker SDK and using tims_open_v2() instead of tims_open(). According to the documentation, this should also allow pressure stabilization(?). Interestingly, it seems to always use re-calibrated data, regardless of what is passed to the recalibration parameter.

If wanted I could make a small PR, but this will break compatibility with previous SDK versions or perhaps an additional function parameter could be used to specify which tims_open() version should be used.

Thanks,
Rick

rickhelmus added a commit to rickhelmus/patRoon that referenced this issue Sep 8, 2022
@qduez
Copy link

qduez commented Feb 20, 2023

Hello,

I am trying to load recalibrated data with opentims, and saw this issue raised by Rick.
I tried to edit the files in the "opentims++" source code folder according to Rick's PR and reinstall the package. However, the "raw" calilbrated data were still loaded. Am I doing something wrong, or is there another way to load recalibrated data ?

Thanks for the help !

mgbaltussen added a commit to mgbaltussen/opentims that referenced this issue Feb 22, 2023
rickhelmus added a commit to rickhelmus/patRoon that referenced this issue Sep 1, 2024
rickhelmus added a commit to rickhelmus/patRoon that referenced this issue Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants