Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update legacy codegen config #319

Merged

Conversation

MrRefactor
Copy link
Contributor

Overview

Current implementation of codegen config contains legacy libraries syntax, I have update it to new version removing the codegen warning:

[Codegen] Found @react-native-community/geolocation
[Codegen] CodegenConfig Deprecated Setup for @react-native-community/geolocation.
    The configuration file still contains the codegen in the libraries array.
    If possible, replace it with a single object.

BEFORE:
    {
      // ...
      "codegenConfig": {
        "libraries": [
          {
            "name": "libName1",
            "type": "all|components|modules",
            "jsSrcsRoot": "libName1/js"
          },
          {
            "name": "libName2",
            "type": "all|components|modules",
            "jsSrcsRoot": "libName2/src"
          }
        ]
      }
    }
    AFTER:
    {
      "codegenConfig": {
        "name": "libraries",
        "type": "all",
        "jsSrcsRoot": "."
      }
    }

Test Plan

Run example app using newArch and validate if builds are passing.

Outcome:
Both iOS and Android builds are passing while using newArch.

@michalchudziak michalchudziak merged commit 0214d5b into michalchudziak:master Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants