Skip to content

Update react-native-geolocation.podspec #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

WoLewicki
Copy link
Contributor

Overview

PR adding new arch compatibility for newest RN version, same PR as e.g. here: react-native-cameraroll/react-native-cameraroll#577

Test Plan

PR adding new arch compatibility for newest RN version, same PR as e.g. here: react-native-cameraroll/react-native-cameraroll#577
@WoLewicki
Copy link
Contributor Author

@michalchudziak could we get this merged and released since it is needed for newest RN to work on new arch 🚀

@michalchudziak
Copy link
Owner

Hey! Sure, I'd love to merge that one, but I would like to understand how will it impact older RN version support. Could you elaborate a bit on that?

@WoLewicki
Copy link
Contributor Author

install_modules_dependencies is available from RN 0.71 iirc. For older versions, you will go into else clause making it work as it worked before. For newer versions, it will automatically add all the needed dependencies based on if app is using old or new arch. You can see some more info here: react-native-webview/react-native-webview#3231 with a comment from Meta member 🚀

@michalchudziak michalchudziak merged commit 0dc53c2 into michalchudziak:master Feb 18, 2024
@WoLewicki WoLewicki deleted the patch-1 branch February 19, 2024 10:02
@WoLewicki
Copy link
Contributor Author

Could we get a quick release with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants