Skip to content

Commit

Permalink
A couple of improvements to JRE test makefiles.
Browse files Browse the repository at this point in the history
- Add dependency test_sources.mk to target AllJreTests.java.
- Remove unused constant FAILING_TESTS

	Change on 2018/09/20 by antoniocortes <antoniocortes@google.com>

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=213819383
  • Loading branch information
antonio-cortes-perez authored and Tom Ball committed Oct 9, 2018
1 parent 05ae774 commit 4537fc5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions jre_emul/test_sources.mk
Original file line number Diff line number Diff line change
Expand Up @@ -841,9 +841,6 @@ TESTS_TO_SKIP = \
org/apache/harmony/tests/javax/net/ssl/SSLSocketFactoryTest.java \
org/apache/harmony/tests/javax/net/ssl/SSLSocketTest.java

FAILING_TESTS = \
libcore/java/text/DateFormatSymbolsTest.java

# Most of these tests are failing for a common index-out-of-range error.
FAILING_MATH_TESTS = \
org/apache/harmony/tests/java/math/BigDecimalArithmeticTest.java \
Expand Down
2 changes: 1 addition & 1 deletion jre_emul/tests.mk
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ $(TEST_BIN): $(TEST_OBJS) $(SUPPORT_LIB) $(DIST_JRE_EMUL_LIB) $(DIST_JUNIT_LIB)
@echo " " $(TEST_JOCC) $(LINK_FLAGS) ...
@$(TEST_JOCC) $(LINK_FLAGS) -o $@ $(TEST_OBJS)

$(ALL_TESTS_SOURCE): tests.mk
$(ALL_TESTS_SOURCE): tests.mk test_sources.mk
@mkdir -p $(@D)
@xcrun awk -f gen_all_tests.sh $(TESTS_TO_RUN) > $@

Expand Down

0 comments on commit 4537fc5

Please sign in to comment.