Repository navigation
[Fusion] Expose the operation plan on PolicyEvaluationContext - #31
Merged
Merged
Conversation
michaelstaib
force-pushed
the
mst/auth-policy-context-plan
branch
from
October 6, 2026 17:08
b0c33ec to
3d6669a
Compare
michaelstaib
added this pull request to stack #33
October 6, 2026 17:20
michaelstaib
force-pushed
the
mst/auth-policy-context-plan
branch
from
October 6, 2026 17:20
3d6669a to
1666140
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: hc-fork-2-jzk.10 (follow-up from your #24 review)
PolicyEvaluationContexttakes theOperationPlanin place ofstring OperationId. It is exposed asPlan, and callers usePlan.Operation.Id. The constructor null-checks the plan. No other member changes.The tests build a real plan through the
FusionTestBasecompose and plan helpers, with no stubs.Verified:
dotnet build src/All.slnx: 0 errors.Minor review notes, not fixed:
PolicyTestHelpercomposes and plans on everyCreateContextcall without caching. The suite still runs in about 2s.PlanFactorysubclassesFusionTestBaseonly to reach its protected static helpers.