Skip to content

[Fusion] Expose the operation plan on PolicyEvaluationContext - #31

Merged
michaelstaib merged 1 commit into
mst/policy-v2from
mst/auth-policy-context-plan
Oct 6, 2026
Merged

michaelstaib merged 1 commit into
mst/policy-v2from
mst/auth-policy-context-plan

Conversation

@michaelstaib

Copy link
Copy Markdown
Owner

Ticket: hc-fork-2-jzk.10 (follow-up from your #24 review)

PolicyEvaluationContext takes the OperationPlan in place of string OperationId. It is exposed as Plan, and callers use Plan.Operation.Id. The constructor null-checks the plan. No other member changes.

The tests build a real plan through the FusionTestBase compose and plan helpers, with no stubs.

Verified:

Minor review notes, not fixed:

  • PolicyTestHelper composes and plans on every CreateContext call without caching. The suite still runs in about 2s.
  • PlanFactory subclasses FusionTestBase only to reach its protected static helpers.

Copilot AI balanced review requested due to automatic review settings October 5, 2026 23:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@michaelstaib
michaelstaib force-pushed the mst/auth-policy-context-plan branch from 3d6669a to 1666140 Compare October 6, 2026 17:20
@michaelstaib
michaelstaib merged commit 73faae1 into mst/policy-v2 Oct 6, 2026
1 check passed
@michaelstaib
michaelstaib deleted the mst/auth-policy-context-plan branch October 6, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants