Repository navigation
[Fusion] Fail composition when a field reads protected fields without their authorization requirements - #30
Merged
Conversation
michaelstaib
force-pushed
the
mst/auth-transitive-require-check
branch
from
October 6, 2026 04:01
f7de989 to
91ce75b
Compare
michaelstaib
force-pushed
the
mst/auth-transitive-require-check
branch
from
October 6, 2026 05:29
91ce75b to
1e6c958
Compare
michaelstaib
force-pushed
the
mst/auth-transitive-require-check
branch
from
October 6, 2026 17:05
1e6c958 to
977176e
Compare
michaelstaib
force-pushed
the
mst/auth-transitive-require-check
branch
from
October 6, 2026 17:09
977176e to
d6636fc
Compare
michaelstaib
force-pushed
the
mst/auth-transitive-require-check
branch
from
October 6, 2026 17:10
d6636fc to
e784b21
Compare
michaelstaib
added this pull request to stack #34
October 6, 2026 17:37
michaelstaib
force-pushed
the
mst/auth-transitive-require-check
branch
from
October 6, 2026 17:38
e784b21 to
97a15be
Compare
Base automatically changed from
mst/auth-interface-inheritance
to
mst/policy-v2
October 6, 2026 17:38
…require or a lookup key without their authorization requirements
…h possible type for authorization requirements
…pe for authorization requirements
michaelstaib
force-pushed
the
mst/auth-transitive-require-check
branch
from
October 6, 2026 17:38
97a15be to
521a00a
Compare
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: hc-fork-2-hdw.4 (Transitive require access check)
Stacked on #29. This PR's diff is against
mst/auth-interface-inheritance.New post-merge rule
AuthorizationTransitiveRequirementsRule. It is a hard composition error that blocks data leaking through dependencies (the class of Apollo advisory GHSA-m8jr-fxqx-8xx6).What counts as a dependency, walked with the
FieldSelectionMapparser:@requireselections, on fields and on arguments, including nested selections, fragments, choices and object construction.How coverage is checked:
@authenticatedon a dependency requires@authenticatedon the requiring field.The error message names the requiring coordinate, the uncovered dependency, the coordinate it was reached through, and the schema. The new code is documented in composition.md.
Needs a planner ruling (comment 271), which could change behavior. The ticket counts lookup keys as dependencies but excludes
@is, and a lookup's key comes from its@isargument. The implementer chose this:@isselections are not walked as a dependency of the lookup field itself.The reviewer also flagged a risk. Under the #29 rule, protecting
idon oneNodetype also protectsNode.id. Combined withnode(id:) @lookup, that may require every field served by any schema with aNodelookup to carry that protection. This was not exercised.Verified:
dotnet build src/All.slnx: 0 errors.These ran before I rebased onto the docs-only #29 commit 2c04c80. The rebase was clean.
Minor review notes, not fixed:
@isexclusion test passes under either interpretation.@requirechoice or fragment.