Repository navigation
Add batch stream tests and a cross-API paging equivalence suite - #16
Merged
michaelstaib merged 4 commits intoOct 4, 2026
Merged
Conversation
michaelstaib
added this pull request to stack #18
October 4, 2026 17:32
michaelstaib
force-pushed
the
mst/tests-batch-streampage
branch
2 times, most recently
from
October 4, 2026 17:33
a670a93 to
69bb36b
Compare
Base automatically changed from
mst/dataloader-branch-key-options
to
mst/ef-paging-batch-streampage
October 4, 2026 17:37
michaelstaib
force-pushed
the
mst/tests-batch-streampage
branch
from
October 4, 2026 17:38
69bb36b to
7de1e4d
Compare
michaelstaib
added a commit
that referenced
this pull request
Oct 4, 2026
* Add cross-API paging equivalence and DataLoader streaming tests * Add relative offset and backward relative scenarios to the paging equivalence suite * Add fetch-based branch state tests for the stream paging DataLoader extensions * Rename StreamPage test cases to name ToStreamPageAsync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the batch stream tests and a cross-API equivalence suite.
PagingEquivalenceTestsruns the same paging arguments throughToPageAsyncandToStreamPageAsync, and throughToBatchPageAsyncandToBatchStreamPageAsyncper key, and compares items, cursors, flags, index and total count directly between the APIs, with cursors taken from real pages rather than written by hand. A new DataLoader test branches a real stream DataLoader, fetches through it, checks the branch state, and shows that branches differing only inIncludeTotalCount,EnableRelativeCursorsorNullOrderingget different keys. Stream test cases that still carriedToPageAsyncin their names are renamed, and their snapshot files move with them; only the snapshot header line that holds the test name changes.One known gap: for a backward relative cursor without a requested total count,
ToBatchStreamPageAsyncreports different page flags thanToBatchPageAsync. Those two scenarios are left out of the suite here and come back with the fix in the next PR.Stack: sits on #15 (
mst/dataloader-branch-key-options).