fixed bevacqua#14, miscalculation on edges for position candidacy

michaelrhodes · Feb 25, 2016 · c3c4d41 · c3c4d41
1 parent df11db5
commit c3c4d41
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/changelog.markdown b/changelog.markdown
@@ -1,3 +1,7 @@
+# 3.6.7 Miscalculation
+
+- Fixed a long-standing bug where candidate positioning would be off by one position
+
 # 3.6.6 Living on the Edge
 
 - Fixed a bug with clicks on IE7, IE8, IE9

diff --git a/dragula.js b/dragula.js
@@ -460,8 +460,8 @@ function dragula (initialContainers, options) {
       for (i = 0; i < len; i++) {
         el = dropTarget.children[i];
         rect = el.getBoundingClientRect();
-        if (horizontal && rect.left > x) { return el; }
-        if (!horizontal && rect.top > y) { return el; }
+        if (horizontal && (rect.left + rect.width / 2) > x) { return el; }
+        if (!horizontal && (rect.top + rect.height / 2) > y) { return el; }
       }
       return null;
     }