-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce http2 #119
introduce http2 #119
Conversation
@jimpil this looks good to me. Thank you! |
Cool - do you need anything else from me here? |
@jimpil resolve the conflicts :) Also, if we are to add a new namespace, I assume we don't have to bump the version to 6.x? Do you agree? |
Conflicts resolved :) Now, regarding bumping major version...If you ask me, I think it's worth doing for two reasons:
To summarise...Even you merge my stuff tonight, the thing is not releasable yet. [EDIT]: omg, I almost forgot! You pretty much have to bump the major version, because consumers will now need Java11+, which is a pretty big change... |
I will bump the version to a 6.0 preview and you are welcome to continue this work. Thank you! |
But first, let's rename the branch to |
Hello, I was just wondering what is happening with this work...The PR has been merged, but none of the post-merge actions have been done. Is there a blocker? Do you need help? |
This has shipped in |
This PR shows a migration path away from
clj-http
. Instead, it uses hato, which wraps the java 11HttpClient
(per #118).What I have done
http.clj
(in its public api, minus the deprecated stuff). In practice, the new api encourages being explicit about what server you're talking to (first argument), and what http-options you want to use (last argument). The globally mutable convenience ofconnect!
still exists, but is backed behind an atom.http-api-test
require tohttp2
(to make sure the tests pass).docker-compose.yml
file (lowers the barrier to contributing)What needs doing (post merge)
http2.clj
http.clj
, replacing the old/existing onehttp-api-test
Let me know if you're happy with how the new namespace looks...It's a little bit longer (even though it has less Vars), but reads nicer/feels simpler, and as I said above, encourages being explicit. Finally, it should be faster, and will take advantage of virtual-threads if available.