Skip to content

Conversation

@michaelfeil
Copy link
Owner

Related Issue

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added tests to cover my changes.
  • I have updated the documentation (docs folder) accordingly.

Additional Notes

Add any other context about the PR here.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates CUDA base images to 12.4.1 and PyTorch to 2.6.0 to support the nomic-ai/nomic-embed-text-v1.5 model, ensuring compatibility across Docker environments.

  • Updated CUDA base images from 12.1.1/12.3.2 to 12.4.1 in both Nvidia and TensorRT Dockerfiles
  • Upgraded PyTorch dependency from 2.4.1 to 2.6.0 in pyproject.toml dev dependencies
  • Changed cudnn9-devel to cudnn-devel in TensorRT base image
  • Maintained ROCm base image at 6.2.3 for AMD compatibility

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.79%. Comparing base (5859c68) to head (b3297ee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...inity_emb/infinity_emb/transformer/acceleration.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   79.86%   79.79%   -0.07%     
==========================================
  Files          43       43              
  Lines        3486     3489       +3     
==========================================
  Hits         2784     2784              
- Misses        702      705       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelfeil michaelfeil merged commit 1c84442 into main Mar 16, 2025
@michaelfeil michaelfeil deleted the mf/torch2.6 branch March 16, 2025 22:50
@michaelfeil michaelfeil restored the mf/torch2.6 branch March 16, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants