Fix: openvino #475
Fix: openvino #475
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the OpenVINO integration strategy by moving from poetry-managed dependencies to direct pip installation in Docker builds, while removing OpenVINO-related dependencies from pyproject.toml.
- Removed OpenVINO packages from pyproject.toml dependencies and extras, commenting out optimum-intel, openvino, and openvino-tokenizers
- Added explicit
onnxruntime-openvinopip installation in Dockerfile.cpu_auto build stages after poetry install - Added new
build-cpuMakefile target for building CPU-specific Docker image with tagmichaelf34/infinity:$(VERSION)-cpu - Set
INFINITY_ENGINE="optimum"as default environment variable in CPU Docker configuration
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| RUN ./requirements_install_from_poetry.sh --no-root --without lint,test "https://download.pytorch.org/whl/cpu" | ||
| RUN poetry run $PYTHON -m pip install --no-cache-dir onnxruntime-openvino |
There was a problem hiding this comment.
logic: Installing onnxruntime-openvino after poetry install could lead to version conflicts with existing dependencies
| RUN poetry run $PYTHON -m pip install --no-cache-dir onnxruntime-openvino | ||
|
|
||
| COPY infinity_emb infinity_emb | ||
| # Install dependency with infinity_emb package | ||
| # "RUN poetry install --no-interaction --no-ansi --extras \"${EXTRAS}\" --without lint,test && poetry cache clear pypi --all" | ||
| COPY requirements_install_from_poetry.sh requirements_install_from_poetry.sh | ||
| RUN ./requirements_install_from_poetry.sh --without lint,test "https://download.pytorch.org/whl/cpu" | ||
| RUN poetry run $PYTHON -m pip install --no-cache-dir onnxruntime-openvino |
There was a problem hiding this comment.
logic: Duplicate installation of onnxruntime-openvino - the second install on line 53 is redundant since the builder stage is already copied to testing
| cache=["diskcache"] | ||
| vision=["colpali-engine","pillow","timm","torchvision"] | ||
| openvino=["onnxruntime-openvino","openvino","openvino-tokenizers"] | ||
| # openvino=["onnxruntime-openvino","openvino","openvino-tokenizers"] |
There was a problem hiding this comment.
logic: Commenting out openvino extras will break backward compatibility for users relying on pip install infinity_emb[openvino]. Consider deprecating gradually instead of removing.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage 79.51% 79.51%
=======================================
Files 41 41
Lines 3417 3417
=======================================
Hits 2717 2717
Misses 700 700 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Related Issue
Checklist
Additional Notes
Add any other context about the PR here.