Spaces fixing and disable all wraps (review this before merge) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IfnotFr
changed the title
IfnotFr
changed the title
|
Sorry for the delay, I was away last week. It's hard to know for sure, as it's not documented specifically, and Laravel tends to wrap things so they look good. There's probably some method to it, but there's nothing obvious in the frameworks |
|
No problem :) I did more digging on wraps and it looks that it depends of the circumstance. And I think that 4bd5b7c is too radical on this. So let me work a little more on this, i will figure it out ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Some spaces fixes according to laravel sources with 861b5d2 and 8fd389f. I tweaked a lot blank lines according to laravel classes with 075e8b6.
With 4bd5b7c i disabled wraps and it is open to discussion. I did not see any wraps of functions, parameters and arrays on laravel source. But maybe should we keep this ?
Thanks :)