Skip to content

Show formatted numbers in the paging when over 1,000 pages #307

Closed
@mgpGit-zz

Description

Angular version:
5.2.11

ngx-pagination version:
3.2.1

Description of issue:
The paging numbers do not have commas in it when the number of pages go past 1,000.
So the number displays as 4300 instead of 4,300.
(We use Server-Side Paging in our app so the number of pages can be large)

Steps to reproduce:
Set the totalItems to be a large number like 20,000 and make the itemsPerPage to be 5.

Expected result:
Show commas in the button page links for easy reading

Actual result:
The pages displayed in the button selection will not have commas in the number.

Demo:
Here is a demo
https://angular-upmtxc.stackblitz.io

Any relevant code:


Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions