Skip to content

Conversation

Copy link

Copilot AI commented Dec 12, 2025

The HDFConverter.__init__ accepted comp and verbose parameters but never used them - they were stored as instance attributes but not passed to the static convert_psp_to_hdf5() method.

Changes:

  • Added comp and verbose parameters to convert_psp_to_hdf5() static method signature
  • __init__ now passes these parameters when calling the static method
  • Implemented functionality:
    • comp: filters conversion to specified component only
    • verbose: enables progress output when > 0

Usage:

# Convert only the 'halo' component with progress messages
HDFConverter('OUT.run0.00000', comp='halo', verbose=1)

# Or use the static method directly
HDFConverter.convert_psp_to_hdf5('OUT.run0.00000', comp='halo', verbose=1)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: michael-petersen <19195541+michael-petersen@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on draft HDF5 converter implementation Fix unused parameters in HDFConverter.__init__ Dec 12, 2025
@michael-petersen michael-petersen marked this pull request as ready for review December 12, 2025 11:53
@michael-petersen michael-petersen merged commit a9c237c into hdf5 Dec 12, 2025
@michael-petersen michael-petersen deleted the copilot/sub-pr-29 branch December 12, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants