Some changes #1
Merged
Some changes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added InvalidInput exception that is raised when input is invalid Used string libary to make the conversion table a bit cleaner Added doc strings and type hints for functions so easy ide support Formatted code with black
If for example the user puts an underscore in the decode function, it will raise an error as '_' is not in the conversion table. Now it will raise an InvalidInput exception which is more informative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add changes list so adding now:
Changes:
hittem with the ol'
black ./(formatted code with black)Added a custom exception to tell people if their input is invalid
Added titles, examples and a markdown table to README
Doc strings and type hints added to functions for IDE autocomplete and hover over help
Used the string library to make the conversion table more cleaner