Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in mypy.ini filename #79

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix typo in mypy.ini filename #79

merged 1 commit into from
Sep 19, 2024

Conversation

tr4nt0r
Copy link
Collaborator

@tr4nt0r tr4nt0r commented Sep 18, 2024

Due to a typo in the filename of mypy's configuration, it was checking with defaults. Pydantic was also missing in the requirements.

@tr4nt0r tr4nt0r requested a review from miaucl September 18, 2024 19:31
@tr4nt0r tr4nt0r added the bug Something isn't working label Sep 18, 2024
@miaucl
Copy link
Owner

miaucl commented Sep 19, 2024

Ok, but seems to find some problems now😅

@tr4nt0r
Copy link
Collaborator Author

tr4nt0r commented Sep 19, 2024

fixing the problems is something for another PR ^^

@miaucl
Copy link
Owner

miaucl commented Sep 19, 2024

fixing the problems is something for another PR ^^

Yes and no, the workflows fail and I think it should be dealt with as we are "enabling" this now.

@tr4nt0r tr4nt0r merged commit 35f37d5 into main Sep 19, 2024
20 checks passed
@tr4nt0r tr4nt0r deleted the rename_mypi branch September 19, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants