feat: migration to newer versions of lc39, tap#394
Draft
ThisIsDemetrio wants to merge 10 commits intomasterfrom
Draft
feat: migration to newer versions of lc39, tap#394ThisIsDemetrio wants to merge 10 commits intomasterfrom
ThisIsDemetrio wants to merge 10 commits intomasterfrom
Conversation
Author
|
We do need wait for a version of lc39 to be released (tecnically a v9.0.0) to use it in here before to mark the pull request as ready to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lc39to latest version (v9) to use Fastify@5tapto latest version (v21.6)Usage of Fastify v9 requires that configuration must come from the
routeOptionsof the request (instead having them injected in the reply from the context). We keep the decoration of the context in the reply, but with a warning that notifies that it will be removed in the previous major (I suppose).Also updated devDependencies to use tap for tests and coverage, and manually include dependency fastify to allow tests dedicated to typings to be run.