Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Makefile #147

Closed
wants to merge 2 commits into from
Closed

added Makefile #147

wants to merge 2 commits into from

Conversation

arademaker
Copy link

@arademaker
Copy link
Author

This PR is not ready to be merged. I got the following compilation error:

flex -8 --prefix=lexc lexc.l
gcc -O3 -Wall -D_GNU_SOURCE -std=c99 -fvisibility=hidden -fPIC -c lex.lexc.c -o lex.lexc.o
bison -v --defines=regex.h --output=regex.c regex.y
regex.y:204.9-16: syntax error, unexpected identifier, expecting string
make: *** [regex.h] Error 1

So it seems that the code from https://bitbucket.org/mhulden/foma/downloads/foma-0.9.18.tar.gz that was the reference to compile the Homebrew formula is different from the source code in this repository although it has the same version number.

Any idea?

@arademaker
Copy link
Author

Can we just replace the code here with the code from the tar.gz file in the bitbucket? But most files in the current repository have an updated copyright Copyright © 2008-2014 Mans Hulden compared to its version in the bitbucket tar.gz

@mhulden
Copy link
Owner

mhulden commented Mar 21, 2023

The project moved to cmake some time ago and the standard Makefile was removed. You can see the Makefile here as it was before deletion.

@arademaker
Copy link
Author

Oh. Sorry, I missed that. So maybe it would be nice to update the README file with the instructions to compile and install with cmake?

The README still says

To compile foma (and flookup) as well as the foma static and dynamic library, "make; make install" should work on most UNIX systems. The default installation target /usr/local can be changed in the Makefile.

@arademaker arademaker closed this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants