Skip to content

fix: streak bonus notification contrast and padding#215

Merged
mholzi merged 1 commit intomainfrom
fix/214-streak-bonus-contrast
Feb 19, 2026
Merged

fix: streak bonus notification contrast and padding#215
mholzi merged 1 commit intomainfrom
fix/214-streak-bonus-contrast

Conversation

@mholzi
Copy link
Owner

@mholzi mholzi commented Feb 19, 2026

Problem (Issue #214)

The 5-streak bonus banner uses a golden/yellow gradient background but inherits white text from the dark theme — making it completely unreadable.

Additionally, the text had only 8px (--space-sm) left padding, making it feel cramped against the edge.

Fix

.streak-bonus-row {
    /* before: no color set → inherited white on yellow = invisible */
    color: #1a1a1a;

    /* before: padding: var(--space-sm) var(--space-sm) (8px all sides) */
    padding: var(--space-sm) var(--space-md); /* 8px top/bottom, 16px left/right */
}

Note: .result-value.is-streak keeps its explicit color: var(--color-error) (#ef4444 red) — red is readable on yellow, no change needed there.

Fixes #214

Golden background with white inherited text caused invisible text.
- color: #1a1a1a ensures dark text is readable on yellow gradient
- padding: var(--space-sm) var(--space-md) adds 16px left/right breathing room

.result-value.is-streak keeps its explicit color-error (red) which
remains readable on yellow background.

Fixes #214
@mholzi mholzi merged commit f55ed71 into main Feb 19, 2026
3 checks passed
@gemini-code-assist
Copy link

Summary of Changes

Hello @mholzi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical UI issue where the streak bonus notification text was unreadable due to poor color contrast against its background. It also improves the visual presentation by adjusting the padding, making the notification more aesthetically pleasing and user-friendly.

Highlights

  • Improved Readability: The text color for the streak bonus banner was changed from an inherited white, which was unreadable against its yellow gradient background, to a dark gray (#1a1a1a) to ensure proper contrast and legibility.
  • Enhanced Layout: The horizontal padding for the streak bonus banner was increased from 8px to 16px, providing more visual space and preventing the text from appearing cramped against the edges.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • custom_components/beatify/www/css/styles.css
    • Set the 'color' property for '.streak-bonus-row' to '#1a1a1a' to improve text readability.
    • Modified the 'padding' property for '.streak-bonus-row' to 'var(--space-sm) var(--space-md)' to increase horizontal spacing.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the contrast issue on the streak bonus banner by setting a dark text color and improves the layout by increasing the horizontal padding. The changes are effective. I have one suggestion to enhance maintainability by using an existing CSS variable for the color instead of a hardcoded value.

padding: var(--space-sm) var(--space-md);
border-radius: var(--radius-md);
margin: var(--space-sm) 0;
color: #1a1a1a;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and consistency with the existing design system, it's recommended to use the defined CSS variable --color-text-dark instead of the hardcoded hex value #1a1a1a.

    color: var(--color-text-dark);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Streak-Bonus Notification — Text nicht sichtbar + fehlender Padding

1 participant

Comments