fix: streak bonus notification contrast and padding#215
Conversation
Golden background with white inherited text caused invisible text. - color: #1a1a1a ensures dark text is readable on yellow gradient - padding: var(--space-sm) var(--space-md) adds 16px left/right breathing room .result-value.is-streak keeps its explicit color-error (red) which remains readable on yellow background. Fixes #214
Summary of ChangesHello @mholzi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical UI issue where the streak bonus notification text was unreadable due to poor color contrast against its background. It also improves the visual presentation by adjusting the padding, making the notification more aesthetically pleasing and user-friendly. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the contrast issue on the streak bonus banner by setting a dark text color and improves the layout by increasing the horizontal padding. The changes are effective. I have one suggestion to enhance maintainability by using an existing CSS variable for the color instead of a hardcoded value.
| padding: var(--space-sm) var(--space-md); | ||
| border-radius: var(--radius-md); | ||
| margin: var(--space-sm) 0; | ||
| color: #1a1a1a; |
Problem (Issue #214)
The 5-streak bonus banner uses a golden/yellow gradient background but inherits white text from the dark theme — making it completely unreadable.
Additionally, the text had only 8px (
--space-sm) left padding, making it feel cramped against the edge.Fix
Note:
.result-value.is-streakkeeps its explicitcolor: var(--color-error)(#ef4444 red) — red is readable on yellow, no change needed there.Fixes #214