Skip to content

fix: result cards carousel — horizontal scroll, one card per view#213

Merged
mholzi merged 1 commit intomainfrom
fix/213-result-cards-carousel
Feb 19, 2026
Merged

fix: result cards carousel — horizontal scroll, one card per view#213
mholzi merged 1 commit intomainfrom
fix/213-result-cards-carousel

Conversation

@mholzi
Copy link
Owner

@mholzi mholzi commented Feb 19, 2026

Problem

PR #211 stacked cards vertically (one per row). This was incorrect.

Correct Design (per Markus)

A horizontal carousel/slider:

  • One card visible at a time (fills full container width)
  • Scroll right to see additional players

CSS Changes

Property Before (#211) After
.results-cards-scroll flex-direction column row
.results-cards-scroll overflow-x auto
.results-cards-scroll gap var(--space-sm) removed
.result-card flex 0 0 100%
.results-cards-scroll {
    display: flex;
    flex-direction: row;
    overflow-x: auto;
    width: 100%;
}
.result-card {
    flex: 0 0 100%;
    width: 100%;
    box-sizing: border-box;
}

Closes #213

Reverts PR #211 vertical-stack approach.
Correct layout per Markus design spec:
- .results-cards-scroll: flex-direction:row, overflow-x:auto
- .result-card: flex:0 0 100%, width:100%

Result: horizontal slider/carousel — each player card fills the full
container width, scroll right to see more players.
@mholzi mholzi merged commit b7ec3df into main Feb 19, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @mholzi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a UI display issue where result cards were incorrectly stacked vertically. The changes transform the card presentation into a horizontal, scrollable carousel, allowing users to view one card at a time and scroll to see additional content. This aligns the component with the intended design for improved user experience.

Highlights

  • UI Layout Correction: Corrected the display of result cards from an incorrect vertical stack to a horizontal carousel, as per the intended design.
  • Flexbox Configuration: Updated the .results-cards-scroll CSS class to use flex-direction: row and overflow-x: auto to enable horizontal scrolling.
  • Card Sizing: Modified the .result-card CSS class to include flex: 0 0 100%, ensuring that only one card is visible at a time within the carousel.
  • Spacing Adjustment: Removed the gap property from .results-cards-scroll as it is no longer needed for the horizontal carousel layout.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • custom_components/beatify/www/css/styles.css
    • Changed flex-direction from column to row for .results-cards-scroll.
    • Added overflow-x: auto to .results-cards-scroll.
    • Removed gap property from .results-cards-scroll.
    • Added flex: 0 0 100% to .result-card.
Activity
  • No activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly changes the result cards from a vertical stack to a horizontal carousel. The CSS changes use flexbox to lay out the cards in a row and ensure each card takes up the full width of the container, with horizontal scrolling enabled. My feedback includes suggestions to implement CSS scroll snapping for a more polished carousel experience, which will make the cards snap into place when scrolling, and a minor code cleanup to remove a redundant CSS property.

Comment on lines 6840 to 6845
.results-cards-scroll {
display: flex;
flex-direction: column;
gap: var(--space-sm);
flex-direction: row;
overflow-x: auto;
width: 100%;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve the carousel experience, consider adding scroll-snap-type. This will make the scroll container snap to the cards, ensuring one card is always neatly in view after scrolling. It provides a more polished feel than free scrolling.

.results-cards-scroll {
    display: flex;
    flex-direction: row;
    overflow-x: auto;
    width: 100%;
    scroll-snap-type: x mandatory;
}

Comment on lines +6863 to 6864
flex: 0 0 100%;
width: 100%;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To complement the scroll snapping on the container, you should add scroll-snap-align: start; to the card. This tells the browser where to align the card within the scroll container.

Also, the width: 100% is redundant because flex: 0 0 100% already sets the flex-basis to 100%, which effectively controls the width in a horizontal flex container. You can safely remove it.

    flex: 0 0 100%;
    scroll-snap-align: start;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments