-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more cases to escapeFormulae, allow to pass RegExp #904
Conversation
I added possibility to pass a RegExp as |
Hi @caub! Thanks for your suggestion. Could you please keep the current tests cases as is (so we ensure nothing is borken) and add a new test case for the regexp validation (the new feature) ? Thanks in advance! |
Hey @pokoli Not sure if really necessary but what's your thought? can we revert my last commit if you prefer? (and then previous tests will be identical) |
I'll start separating anyway so it's clearer, you're right |
@caub feel free to remove some test suit if it is no longer valid (but please keep the valid ones) |
ok done, https://github.com/mholt/PapaParse/pull/904/files you can see 2 of the previous tests are affected, because for example |
yep, done |
Merged it. Thanks |
See #796 #793
@pokoli @wcerfgba Hey guys, could you check this PR?
It adds more cases for
escapeFormulae
option, cf https://owasp.org/www-community/attacks/CSV_Injection