Ignore package-lock.json #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapaParse should either commit package-lock.json, or explicitly ignore it. npm still has some bugs that cause a lot of package-lock.json churn, which will be compounded by PapaParse's support for older Node (and npm) versions. So let's go with ignore for now.
|
Thanks for your contribution! |
gabegorelick
added a commit
to gabegorelick/PapaParse
that referenced
this pull request
Apr 9, 2018
This is similar to mholt#476. It allows devs to use yarn to manage their dependencies if they want.
Merged
pokoli
pushed a commit
that referenced
this pull request
Apr 10, 2018
Similar to #476. It allows developers to use yarn to manage their dependencies if they want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PapaParse should either commit package-lock.json, or explicitly ignore it. npm still has some bugs that cause a lot of package-lock.json churn, which will be compounded by PapaParse's support for older Node (and npm) versions. So let's go with ignore for now.
jQuery made a similar decision: jquery/jquery@7037fac