Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- presumably fixed bug #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

- presumably fixed bug #8

wants to merge 1 commit into from

Conversation

lotruheawea
Copy link

adresses #7,

  • reason: bbox comparison in shrink and enlarge routines is imprecise due to rounding errors
  • this occurs at larger grids
  • the PRECISION of 10 seems reasonable and fixed the setup of a 3600x7200 grid
  • needs to be checked and tested

MuellerSeb
MuellerSeb requested changes Sep 28, 2022
View reviewed changes
Copy link
Member

@MuellerSeb MuellerSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it! One comment, then we are good to go.

src/basinex/geoarray/spatial.py
@@ -4,6 +4,9 @@

import numpy as np

# precision for rounding to avoid numerical instabilities
PRECISION = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add this as an optional argument to the config yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MuellerSeb MuellerSeb MuellerSeb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lotruheawea @MuellerSeb @gitporst