Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jan 7, 2026

This PR contains the following updates:

Package Change Age Confidence
globals ^16.5.0^17.0.0 age confidence

Release Notes

sindresorhus/globals (globals)

v17.2.0

Compare Source

  • jasmine: Add throwUnless and throwUnlessAsync globals (#​335) 97f23a7

v17.1.0

Compare Source


v17.0.0

Compare Source

Breaking
Improvements


Configuration

📅 Schedule: Branch creation - "before 4am on Wednesday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate using a curated preset maintained by mheob. View repository job log here

@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
eslint-config Ready Ready Preview, Comment Jan 27, 2026 7:14pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

⚠️ No Changeset found

Latest commit: 3ef6ddf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link

claude bot commented Jan 7, 2026

Pull Request Review: Update globals to v17

Summary

This PR updates the globals package from v16.5.0 to v17.0.0. This is a major version update by Renovate bot.

Analysis

Breaking Changes

According to the release notes, there is one breaking change:

  • Split audioWorklet environment from browser: The audioWorklet globals are no longer included in the browser environment and must be explicitly imported if needed.

Impact Assessment

Low Risk - I reviewed the codebase usage of globals:

  • The package is used in packages/eslint-config/src/configs/javascript.ts:1
  • Current usage imports: globals.browser, globals.es2021, and globals.node
  • No audioWorklet usage detected, so the breaking change does not affect this codebase

Benefits of Update

The v17 update includes several improvements:

  • Updated global definitions for better accuracy
  • Browser globals now sourced from both Chrome and Firefox for better coverage
  • New environments added: bunBuiltin, denoBuiltin, paintWorklet, and sharedWorker
  • Separated audioWorklet environment for more precise configuration

Lock File Changes

The pnpm-lock.yaml shows a clean dependency tree update with no unexpected changes. The update removes several unused transitive dependencies and updates related packages (@typescript-eslint/*, browserslist, etc.) which is expected behavior for a major version bump.

Recommendations

Safe to merge - This update:

  1. Does not introduce breaking changes for this codebase's usage pattern
  2. Provides more accurate and up-to-date global definitions
  3. Follows the repository's automated dependency update workflow
  4. Lock file changes are clean and expected

Testing Suggestions

Before merging, consider:

  1. Running pnpm build to ensure all packages compile successfully
  2. Running pnpm lint to verify ESLint configurations work correctly with the new globals
  3. Verifying any CI/CD pipelines pass

Note: If you use AudioWorklet APIs anywhere in your projects that consume this ESLint config, you may need to update your ESLint configuration to explicitly include the audioWorklet environment in the future.

@claude
Copy link

claude bot commented Jan 8, 2026

Pull Request Review: globals v17 Upgrade

Summary

This PR updates the globals package from v16.5.0 to v17.0.0, a major version bump with breaking changes.


Code Quality ✅

  • Lockfile changes look clean: The dependency update is properly reflected in pnpm-lock.yaml with all transitive dependencies updated correctly.
  • Catalog management: Using the catalog versioning system ensures consistency across the monorepo.

Breaking Changes Analysis ⚠️

According to the release notes, the key breaking change is:

audioWorklet environment split from browser (#320)

  • Previously, audioWorklet globals were included in the browser environment
  • Now they're in a separate environment that must be explicitly imported if needed

Impact Assessment:

In packages/eslint-config/src/configs/javascript.ts:26, the code uses:

globals: {
  ...globals.browser,
  ...globals.es2021,
  ...globals.node,
  // ...
}

Risk: If your codebase or consumers use AudioWorklet APIs, they may now see no-undef ESLint errors for audioWorklet-specific globals.

Recommendation:

  • If AudioWorklet support is needed, explicitly add ...globals.audioWorklet to the globals configuration
  • Otherwise, this change is transparent (audioWorklet globals are rarely used in typical web apps)

New Features 🎉

The release adds several useful new environments:

  • bunBuiltin - Bun runtime built-in globals
  • denoBuiltin - Deno runtime built-in globals
  • paintWorklet - Paint Worklet API globals
  • sharedWorker - Shared Worker globals

These could be valuable additions if your config supports these runtimes/APIs.


Security Concerns ✅

No security issues identified. This is a maintenance update from a trusted source (sindresorhus).


Performance Considerations ✅

  • The updated browser globals now pull from both Chrome and Firefox sources (#321), providing more comprehensive coverage
  • No performance degradation expected from this change

Testing Recommendations 📋

Before merging, I recommend:

  1. Build verification: Ensure pnpm build succeeds across all packages
  2. Consumer testing: If possible, test in a project that uses @mheob/eslint-config to verify no unexpected ESLint errors surface
  3. AudioWorklet check: Grep the codebase for AudioWorklet usage:
    git grep -i "audioworklet" "*.{js,ts,jsx,tsx}"
    If found, add ...globals.audioWorklet to the globals config

Verdict 🚦

Recommendation: ✅ Approve with minor caveat

This is a solid dependency update. The breaking change is narrow in scope (audioWorklet split) and unlikely to impact most users. The improvements to browser global coverage are beneficial.

Action items before merge:

  • Verify no AudioWorklet usage in consumer projects (or add globals.audioWorklet if needed)
  • Consider creating a changeset documenting this as a potentially breaking change for consumers using AudioWorklet APIs
  • Optional: Consider leveraging the new runtime environments (bunBuiltin, denoBuiltin) if you plan to support those platforms

Generated by Claude Code

@renovate renovate bot force-pushed the renovate/globals-17.x branch from 63b40fd to 3ef6ddf Compare January 27, 2026 19:13
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants