Skip to content

fix: always use forward slashes in glob pattern - #211

Open
cyyynthia wants to merge 1 commit into
mheap:mainfrom
cyyynthia:windows-compat
Open

cyyynthia wants to merge 1 commit into
mheap:mainfrom
cyyynthia:windows-compat

Conversation

@cyyynthia

Copy link
Copy Markdown

This fixes an incompatibility with Windows systems, where the glob pattern would contain backward slashes due to the use of path.join.

@mheap

mheap commented Jun 29, 2025

Copy link
Copy Markdown
Owner

@cyyynthia Could you share the sample output that you see on Windows? I'd expect backslashes to be used here as it's a directory

@cyyynthia

Copy link
Copy Markdown
Author

I don't have my machine around, but it basically just fails to find any yaml file whenever using a directory. Works fine when pointing at a yaml file directly.

Moreover, the fast-glob documentation is pretty clear on the fact that only forward slashes should be used even on Windows.

@cyyynthia

Copy link
Copy Markdown
Author

The script simply fails saying Didn't find Y(A)ML files in provided paths: .github/workflows.

Here is the warning in the documentation I was referring to about forward vs backward slashes: https://github.com/mrmlnc/fast-glob#pattern-syntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants