Skip to content

Convert other params to snake case #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert other params to snake case #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/remote/paged-remote-array.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default Ember.ArrayProxy.extend(Ember.Evented, ArrayProxyPromiseMixin, {
for (var key in otherOps) {
Util.log("otherOps key " + key);
var val = otherOps[key];
ops[key] = val;
ops[key.underscore()] = val;
}

return ops;
Expand Down
10 changes: 7 additions & 3 deletions tests/unit/lib/remote/paged-remote-array-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ asyncTest("change page", function() {
paged.then(function() {
QUnit.start();
equalArray(paged,[1,2]);

paged.runSet("page",2);

paged.then(function() {
Expand Down Expand Up @@ -211,8 +211,12 @@ test("paramsForBackend with param mapping", function() {
deepEqual(res,{currentPage: 1, per_page: 2});
});



test("paramsForBackend with otherParams converted to snakecased", function () {
var store = MockStore.create();
var paged = PagedRemoteArray.create({store: store, modelName: 'number', page: 1, perPage: 2, otherParams: {firstName: "Adam"}});
var res = paged.get('paramsForBackend');
deepEqual(res,{page: 1, per_page: 2, first_name: "Adam"});
});

asyncTest("basic meta", function() {
var store = FakeStore.create({all: [1,2,3,4,5]});
Expand Down