Skip to content

Commit

Permalink
contrib: git-remote-{bzr,hg} placeholders don't need Python
Browse files Browse the repository at this point in the history
It does not make sense for these placeholder scripts to depend on Python
just because the real scripts do. At the example of Git for Windows, we
would not even be able to see those warnings as it does not ship with
Python. So just use plain shell scripts instead.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
sschuberth authored and gitster committed Mar 3, 2017
1 parent e7e07d5 commit b8686c6
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 18 deletions.
16 changes: 7 additions & 9 deletions contrib/remote-helpers/git-remote-bzr
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
#!/usr/bin/env python
#!/bin/sh

import sys

sys.stderr.write('WARNING: git-remote-bzr is now maintained independently.\n')
sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-bzr\n')

sys.stderr.write('''WARNING:
cat >&2 <<'EOT'
WARNING: git-remote-bzr is now maintained independently.
WARNING: For more information visit https://github.com/felipec/git-remote-bzr
WARNING:
WARNING: You can pick a directory on your $PATH and download it, e.g.:
WARNING: $ wget -O $HOME/bin/git-remote-bzr \\
WARNING: $ wget -O $HOME/bin/git-remote-bzr \
WARNING: https://raw.github.com/felipec/git-remote-bzr/master/git-remote-bzr
WARNING: $ chmod +x $HOME/bin/git-remote-bzr
''')
EOT
16 changes: 7 additions & 9 deletions contrib/remote-helpers/git-remote-hg
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
#!/usr/bin/env python
#!/bin/sh

import sys

sys.stderr.write('WARNING: git-remote-hg is now maintained independently.\n')
sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-hg\n')

sys.stderr.write('''WARNING:
cat >&2 <<'EOT'
WARNING: git-remote-hg is now maintained independently.
WARNING: For more information visit https://github.com/felipec/git-remote-hg
WARNING:
WARNING: You can pick a directory on your $PATH and download it, e.g.:
WARNING: $ wget -O $HOME/bin/git-remote-hg \\
WARNING: $ wget -O $HOME/bin/git-remote-hg \
WARNING: https://raw.github.com/felipec/git-remote-hg/master/git-remote-hg
WARNING: $ chmod +x $HOME/bin/git-remote-hg
''')
EOT

0 comments on commit b8686c6

Please sign in to comment.