Skip to content

Commit

Permalink
Make Sass Spec npm installable
Browse files Browse the repository at this point in the history
Node Sass to have Sass Spec specs as dependency for inclusion in
the node-citgm. The requirement for being the citgm is that a
packages tests should be executable via `npm install`.

This means Node Sass needs to publish it's tests to npm. That
includes Sass Spec. At the moment Sass Spec is a git submodule so
we'd need to publish the entire repo. This is a [problem][1] as
Sass Spec weighs in at 69M.

Size aside some users have experienced issues with some unicode
[file names][2] and [long paths][3]. To get around these issues
we want remove the git submodule and instead `npm install` the
Sass Spec spec files. We'd do this a `devDependency` so regular
users won't install them which avoids the previously mentioned issues.
Having only the specs files in npm package will also hugely reduce
the package size.

[1]: https://twitter.com/nodkz/status/773103622678798336
[2]: sass/node-sass#1699
[3]: sass/node-sass#1701
  • Loading branch information
xzyfer committed Nov 14, 2016
1 parent 806c1dc commit bc07b3a
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
3 changes: 3 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
dirname: __dirname,
};
23 changes: 23 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"name": "sass-spec",
"version": "3.4.0-0",
"description": "Test suite for testing compatibility with the Sass Stylesheet language.",
"main": "index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/sass/sass-spec.git"
},
"keywords": [
"sass"
],
"files": [
"spec",
"index.js"
],
"author": "Michael Mifsud <xzyfer@gmail.com>",
"license": "MIT",
"bugs": {
"url": "https://github.com/sass/sass-spec/issues"
},
"homepage": "https://github.com/sass/sass-spec#readme"
}

0 comments on commit bc07b3a

Please sign in to comment.