Add content security policy #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents inline javascript and cross site scripting. This breaks live reload in local development. Will move csp to _wrangler.ts to allow different csp for dev and production. Current exceptions: font-src * for carbon components that use IBM CDN for fonts (will look into bundling fonts with site instead) style-src 'unsafe-inline' required for plotlyjs image-src * currently users can paste image links into quill editor, will look into disabling this capability image-src data: required if user pastes image into quill editor image-src blob: needed when plotlyjs downloads plot as png
Fonts are now bundled after merging #139
This makes it easy to have a different CSP for dev mode to enable live reload.
This silences some TS errors
Use origin instead. Doesn't really impact anything except for the URL's stored in the history since front end was using getHash for everything anyway
|
Merging #139 allowed for the removal of the font exception. The following CSP exceptions are still in place:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents inline javascript and cross site scripting.
This breaks live reload in local development. Will move csp to _worker.ts to allow different csp for dev and production.
Current exceptions:
font-src *for carbon components that use IBM CDN for fonts (will look into bundling fonts with site instead)style-src 'unsafe-inline'required for plotly.js ( see this plotly issue )image-src *currently users can paste image links into quill editor, will look into disabling this capabilityimage-src data:required if user inserts image as base64 image into quill editorimage-src blob:needed when plotly.js downloads plot as png