Skip to content

Commit

Permalink
fix: fix unintentional canceling of dimensions
Browse files Browse the repository at this point in the history
Fixes a bug introduced in previous commit
  • Loading branch information
mgreminger committed Oct 5, 2024
1 parent 8bfc41e commit 83579fb
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion public/dimensional_analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ class ExprWithAssumptions(Expr):
information,
)

dimensions = (mass, length, time, current, temperature, luminous_intensity,
amount_of_substance, angle, information)
dimension_symbols = set((dimension.name for dimension in dimensions))

from sympy.physics.units.systems.si import dimsys_SI

from sympy.utilities.iterables import topological_sort
Expand Down Expand Up @@ -1640,7 +1644,7 @@ def get_dimensional_analysis_expression(parameter_subs: dict[Symbol, Expr],

def custom_get_dimensional_dependencies(expression: Expr | None):
if expression is not None:
expression = subs_wrapper(expression, {cast(Symbol, symbol): sympify('1') for symbol in expression.free_symbols})
expression = subs_wrapper(expression, {cast(Symbol, symbol): sympify('1') for symbol in (expression.free_symbols - dimension_symbols)})
return dimsys_SI.get_dimensional_dependencies(expression)

def dimensional_analysis(dimensional_analysis_expression: Expr | None, dim_sub_error: Exception | None,
Expand Down

0 comments on commit 83579fb

Please sign in to comment.