Skip to content

Updating NuGet packages, target SDK and framework targets. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2020

Conversation

stebet
Copy link
Contributor

@stebet stebet commented Feb 28, 2020

  • Updated global.json to target the latest 3.1 SDK.
  • Updated NuGet references (no more preview packages!).
  • Changed obsolete Attributes in the Banchmark project and changed targets to netcoreapp3.1 and net48 as benchmark jobs.

@mgravell
Copy link
Owner

fixing the Microsoft.Bcl.AsyncInterfaces and other lib dependencies - yup, makes perfect sense

re the SDK file; unless we need specific SDK features, it may be preferable to be more flexible; example for consideration - this is far less picky

however, I'm a little less certain about the change from netcoreapp3.0 to netcoreapp3.1; is there an actual reason for this? netcoreapp3.1 can still consume the netcoreapp3.0 TFM, so this reduces TFM coverage without (as far as I can tell) any other purpose; is that intentional?

@stebet
Copy link
Contributor Author

stebet commented Feb 28, 2020

SDK file: makes sense, I will update it.
TFM: No, think I just went a bit overboard with updating, will revert that back to netcoreapp3.0, doesn't make sense to update that to 3.1.

Making the SDK target possible to roll forward.
@stebet
Copy link
Contributor Author

stebet commented Feb 28, 2020

Updated, I kept the tests and benchmark as targets to 3.1 and .NET Framework 4.8, but that could of course be rolled back as well, although that does check the consumption of the netcoreapp3.0 TFM in a netcoreapp3.1 project, so maybe that makes sense?

@mgravell
Copy link
Owner

tests and benchmark update is fine

@mgravell
Copy link
Owner

looks good, thanks

@mgravell mgravell merged commit be028e4 into mgravell:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants