[WIP] Change table to definition list in MetadataTable #774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a "proposal in code" that illustrates switching MetadataTable to use definition lists rather than tables. The current form is deliberately minimal to make absolutely clear what I'm proposing, but I wouldn't consider it complete. See below for possible additional work.
The benefits of using
<dl>
versus<table>
include:Motivating use case: When I discovered this feature, I was already using Kanban for project notes with a
Complete when::
metadata tag. But the use of tables forces a side-by-side presentation of each key/value pair, which was visually awkward for long keys (like this one) AND for long value text.Here's a "before" image of the current codebase (v1.5.2) using
<table>
:For comparison, here's how it looks with
<dl>
, but zero styling work:If this seems like a good direction, likely next steps are:
color: var(--text-muted)
styling was droppedDoes this seem like a desirable approach? If so, what changes would you like to land this plugin?