Skip to content

Conversation

mathewmeconry
Copy link
Contributor

As requested in pull #15 I created a new pull

@mathewmeconry
Copy link
Contributor Author

@mtimofiiv can you check that one?

@mtimofiiv
Copy link
Contributor

This looks great, thanks @mathewmeconry! However there appears to be a merge conflict preventing me from merging, in package-lock.json of all places. The weird thing is that this repo does not have a lockfile at all.

Once it's resolved, I will merge this!

@mathewmeconry
Copy link
Contributor Author

Hey @mtimofiiv
Thanks for the review.
I fixed the conflict and updated my branch with your master.

You should consider adding the package-lock.json to the repo. Because then the package versions of your dependencies are fixed and don't have unwanted side effects when newer versions are downloaded.

@mathewmeconry
Copy link
Contributor Author

Hi @mtimofiiv
Some time has passed and I wanted to check in if you can merge this now or if there are any other issues

@mathewmeconry
Copy link
Contributor Author

Hi @mtimofiiv
Some time has passed and I wanted to check in if you can merge this now or if there are any other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants