Add InstallerExistingConfigTestBase to BrowserTestBaseDefaultThemeRule exclusion [#780] #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglaman
reviewed
Jul 9, 2024
Comment on lines
72
to
76
| $excludedTestTypes = TypeCombinator::union( | ||
| new ObjectType('Drupal\\FunctionalTests\\Update\\UpdatePathTestBase'), | ||
| new ObjectType('Drupal\\FunctionalTests\\Installer\\InstallerConfigDirectoryTestBase'), | ||
| new ObjectType('Drupal\\FunctionalTests\\Installer\\InstallerExistingConfigTestBase') | ||
| ); |
Owner
There was a problem hiding this comment.
We should only add it to the union if Drupal core is > 10.3.
Contributor
Author
There was a problem hiding this comment.
It's a brand new class, will it fail if it is in the union and it does not exist?
mglaman
changed the title
mglaman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should include the exclusion for the new class to match the now deprecated InstallerExistingConfigTestBase.