Skip to content

Add stubs for core field types #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions extension.neon
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,37 @@ parameters:
- engine
scanFiles:
- stubs/Twig/functions.stub
stubFiles:
- stubs/Drupal/Component/Plugin/PluginInspectionInterface.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldItemBase.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldItemInterface.stub
- stubs/Drupal/Core/Field/Plugin/Field/PreconfiguredFieldUiOptionsInterface.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/BooleanItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/ChangedItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/CreatedItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/DecimalItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/EmailItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/EntityReferenceItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/FloatItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/IntegerItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/LanguageItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/MapItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/NumericItemBase.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/PasswordItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/StringItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/StringItemBase.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/StringLongItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/TimestampItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/UriItem.stub
- stubs/Drupal/Core/Field/Plugin/Field/FieldType/UuidItem.stub
- stubs/Drupal/Core/TypedData/ComplexDataInterface.stub
- stubs/Drupal/Core/TypedData/OptionsProviderInterface.stub
- stubs/Drupal/Core/TypedData/TraversableTypedDataInterface.stub
- stubs/Drupal/Core/TypedData/TypedData.stub
- stubs/Drupal/Core/TypedData/TypedDataInterface.stub
- stubs/Drupal/Core/TypedData/Plugin/DataType/Map.stub
- stubs/Drupal/link/LinkItemInterface.stub
- stubs/Drupal/link/Plugin/Field/FieldType/LinkItem.stub
drupal:
drupal_root: '%currentWorkingDirectory%'
entityMapping:
Expand Down
1 change: 1 addition & 0 deletions src/Reflection/FieldItemListPropertyReflection.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public function getReadableType(): Type
return new ObjectType('Drupal\Core\Entity\EntityInterface');
}
if ($this->propertyName === 'target_id') {
// @todo needs to be union type.
return new StringType();
}
// @todo this is wrong, integer/bool/decimal/etc all use single value property.
Expand Down
6 changes: 6 additions & 0 deletions stubs/Drupal/Component/Plugin/PluginInspectionInterface.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Component\Plugin;

interface PluginInspectionInterface {
}
8 changes: 8 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldItemBase.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?php

namespace Drupal\Core\Field;

use Drupal\Core\TypedData\Plugin\DataType\Map;

abstract class FieldItemBase extends Map implements FieldItemInterface {
}
8 changes: 8 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldItemInterface.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?php

namespace Drupal\Core\Field;

use Drupal\Core\TypedData\ComplexDataInterface;

interface FieldItemInterface extends ComplexDataInterface {
}
12 changes: 12 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldType/BooleanItem.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

use Drupal\Core\Field\FieldItemBase;
use Drupal\Core\TypedData\OptionsProviderInterface;

/**
* @property int $value
*/
class BooleanItem extends FieldItemBase implements OptionsProviderInterface {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

class ChangedItem extends CreatedItem {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

class CreatedItem extends TimestampItem {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

/**
* @property string $value
*/
class DecimalItem extends NumericItemBase {
}
11 changes: 11 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldType/EmailItem.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

use Drupal\Core\Field\FieldItemBase;

/**
* @property string $value
*/
class EmailItem extends FieldItemBase {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

use Drupal\Core\Field\FieldItemBase;
use Drupal\Core\Field\PreconfiguredFieldUiOptionsInterface;
use Drupal\Core\TypedData\OptionsProviderInterface;

/**
* @property string|integer $target_id
* @property \Drupal\Core\Entity\EntityInterface $entity
*/
class EntityReferenceItem extends FieldItemBase implements OptionsProviderInterface, PreconfiguredFieldUiOptionsInterface {
}
9 changes: 9 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldType/FloatItem.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

/**
* @property float $value
*/
class FloatItem extends NumericItemBase {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

/**
* @property int $value
*/
class IntegerItem extends NumericItemBase {
}
13 changes: 13 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldType/LanguageItem.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

use Drupal\Core\Field\FieldItemBase;
use Drupal\Core\TypedData\OptionsProviderInterface;

/**
* @property string $value
* @property \Drupal\Core\Language\LanguageInterface $language
*/
class LanguageItem extends FieldItemBase implements OptionsProviderInterface {
}
11 changes: 11 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldType/MapItem.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

use Drupal\Core\Field\FieldItemBase;

/**
* @property array<string, mixed> $value
*/
class MapItem extends FieldItemBase {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

use Drupal\Core\Field\FieldItemBase;

abstract class NumericItemBase extends FieldItemBase {
}
10 changes: 10 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldType/PasswordItem.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

/**
* @property ?string $existing
* @property bool $pre_hashed
*/
class PasswordItem extends StringItem {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

class StringItem extends StringItemBase {
}
11 changes: 11 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldType/StringItemBase.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

use Drupal\Core\Field\FieldItemBase;

/**
* @property string $value
*/
abstract class StringItemBase extends FieldItemBase {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

class StringLongItem extends StringItemBase {
}
11 changes: 11 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldType/TimestampItem.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

use Drupal\Core\Field\FieldItemBase;

/**
* @property string $value
*/
class TimestampItem extends FieldItemBase {
}
6 changes: 6 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldType/UriItem.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

class UriItem extends StringItem {
}
6 changes: 6 additions & 0 deletions stubs/Drupal/Core/Field/Plugin/Field/FieldType/UuidItem.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Core\Field\Plugin\Field\FieldType;

class UuidItem extends StringItem {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Core\Field;

interface PreconfiguredFieldUiOptionsInterface {
}
6 changes: 6 additions & 0 deletions stubs/Drupal/Core/TypedData/ComplexDataInterface.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Core\TypedData;

interface ComplexDataInterface extends TraversableTypedDataInterface {
}
6 changes: 6 additions & 0 deletions stubs/Drupal/Core/TypedData/OptionsProviderInterface.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Core\TypedData;

interface OptionsProviderInterface {
}
12 changes: 12 additions & 0 deletions stubs/Drupal/Core/TypedData/Plugin/DataType/Map.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php

namespace Drupal\Core\TypedData\Plugin\DataType;

use Drupal\Core\TypedData\TypedData;
use Drupal\Core\TypedData\ComplexDataInterface;

/**
* @implements \IteratorAggregate<string, \Drupal\Core\TypedData\TypedDataInterface>
*/
class Map extends TypedData implements \IteratorAggregate, ComplexDataInterface {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

namespace Drupal\Core\TypedData;

/**
* @extends \Traversable<string, \Drupal\Core\TypedData\TypedDataInterface>
*/
interface TraversableTypedDataInterface extends TypedDataInterface, \Traversable {
}
8 changes: 8 additions & 0 deletions stubs/Drupal/Core/TypedData/TypedData.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?php

namespace Drupal\Core\TypedData;

use Drupal\Component\Plugin\PluginInspectionInterface;

abstract class TypedData implements TypedDataInterface, PluginInspectionInterface {
}
6 changes: 6 additions & 0 deletions stubs/Drupal/Core/TypedData/TypedDataInterface.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

namespace Drupal\Core\TypedData;

interface TypedDataInterface {
}
8 changes: 8 additions & 0 deletions stubs/Drupal/link/LinkItemInterface.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?php

namespace Drupal\link;

use Drupal\Core\Field\FieldItemInterface;

interface LinkItemInterface extends FieldItemInterface {
}
15 changes: 15 additions & 0 deletions stubs/Drupal/link/Plugin/Field/FieldType/LinkItem.stub
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php

namespace Drupal\link\Plugin\Field\FieldType;

use Drupal\Core\Field\FieldItemBase;
use Drupal\link\LinkItemInterface;

/**
* @property string $uri
* @property string $title
* @property array<string, mixed> $options
*/
class LinkItem extends FieldItemBase implements LinkItemInterface {

}
33 changes: 33 additions & 0 deletions tests/src/Type/FieldTypesTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?php

declare(strict_types=1);

namespace mglaman\PHPStanDrupal\Tests\Type;

use mglaman\PHPStanDrupal\Tests\AdditionalConfigFilesTrait;
use PHPStan\Testing\TypeInferenceTestCase;

final class FieldTypesTest extends TypeInferenceTestCase
{
use AdditionalConfigFilesTrait;

public function dataFileAsserts(): iterable
{
yield from $this->gatherAssertTypes(__DIR__ . '/data/field-types.php');
}

/**
* @dataProvider dataFileAsserts
* @param string $assertType
* @param string $file
* @param mixed ...$args
*/
public function testFileAsserts(
string $assertType,
string $file,
...$args
): void
{
$this->assertFileAsserts($assertType, $file, ...$args);
}
}
Loading