Cannot find symbol class R

[ruturajpatki]

Bug Description
The error is in Ratings Plugin - import mgks.os.swv.R;

Expected Behavior
I have NOT enabled the Ratings plugin, but since the Java file is a part of project, it shows the compile error and therefore the compile fails.

Any Logs/Screenshots

[mgks]

Seems like migrating rating library into plugins still left some hardcoded fragments behind. We're basically going to decouple plugins from using resources from the main app.

Replace RatingPlugin.java with this:

package mgks.os.swv.plugins;

/*
  Rating Plugin for Smart WebView

  This is a core plugin and is covered by the MIT license of the Smart WebView project.

  This plugin prompts users to rate the application on the Google Play Store after
  certain usage conditions (e.g., number of launches, days since install) are met.

  FEATURES:
  - Configurable conditions for showing the dialog.
  - Standard three-button dialog: "Rate Now", "Later", "No, Thanks".
  - Remembers user's choice to avoid repeated prompts.
  - Opens the app's Google Play Store page.

  USAGE:
  1. This plugin is typically self-activating based on its configuration.
  2. To configure, modify the default values in the plugin's static initializer
     or use Playground.java to set them dynamically.
  3. Enable/disable the entire feature with the `ASWP_RATINGS` flag in SWVContext.java.
*/

import android.annotation.SuppressLint;
import android.app.Activity;
import android.app.AlertDialog;
import android.content.Context;
import android.content.Intent;
import android.content.SharedPreferences;
import android.net.Uri;
import android.util.Log;
import android.webkit.WebView;

import androidx.annotation.NonNull;

import java.util.Date;
import java.util.HashMap;
import java.util.Map;

import mgks.os.swv.Functions;
import mgks.os.swv.PluginInterface;
import mgks.os.swv.PluginManager;
import mgks.os.swv.R;
import mgks.os.swv.SWVContext;

public class RatingPlugin implements PluginInterface {
    private static final String TAG = "RatingPlugin";
    private Activity activity;

    private static final String DIALOG_TITLE = "Rate Our App";
    private static final String DIALOG_MESSAGE = "If you enjoy using this app, would you mind taking a moment to rate it? Thanks for your support!";
    private static final String BUTTON_RATE_NOW = "RATE NOW";
    private static final String BUTTON_REMIND_LATER = "LATER";
    private static final String BUTTON_NO_THANKS = "NO, THANKS";

    // SharedPreferences keys
    private static final String PREF_NAME = "swv_rating_plugin_prefs";
    private static final String KEY_INSTALL_DATE = "install_date";
    private static final String KEY_LAUNCH_TIMES = "launch_times";
    private static final String KEY_DONT_SHOW_AGAIN = "dont_show_again";
    private static final String KEY_REMIND_LATER_DATE = "remind_later_date";

    static {
        // No default config needed as it's read from SWVContext
        PluginManager.registerPlugin(new RatingPlugin(), new HashMap<>());
    }

    @Override
    public void initialize(Activity activity, WebView webView, Functions functions, Map<String, Object> config) {
        this.activity = activity;
        Log.d(TAG, "RatingPlugin initialized.");
        monitor();
        if (shouldShowRateDialog()) {
            showRateDialog();
        }
    }

    private SharedPreferences getPrefs() {
        return activity.getSharedPreferences(PREF_NAME, Context.MODE_PRIVATE);
    }

    private void monitor() {
        SharedPreferences prefs = getPrefs();
        SharedPreferences.Editor editor = prefs.edit();

        int currentLaunchTimes = prefs.getInt(KEY_LAUNCH_TIMES, 0) + 1;
        editor.putInt(KEY_LAUNCH_TIMES, currentLaunchTimes);

        if (prefs.getLong(KEY_INSTALL_DATE, 0) == 0) {
            editor.putLong(KEY_INSTALL_DATE, System.currentTimeMillis());
        }
        editor.apply();
    }

    private boolean shouldShowRateDialog() {
        SharedPreferences prefs = getPrefs();

        if (prefs.getBoolean(KEY_DONT_SHOW_AGAIN, false)) {
            return false;
        }
        if (prefs.getInt(KEY_LAUNCH_TIMES, 0) < SWVContext.ASWR_TIMES) {
            return false;
        }

        long currentTime = System.currentTimeMillis();
        long installDate = prefs.getLong(KEY_INSTALL_DATE, 0);
        long remindLaterDate = prefs.getLong(KEY_REMIND_LATER_DATE, 0);

        if (currentTime < installDate + (long) SWVContext.ASWR_DAYS * 24 * 60 * 60 * 1000) {
            return false;
        }
        if (remindLaterDate != 0 && currentTime < remindLaterDate + (long) SWVContext.ASWR_INTERVAL * 24 * 60 * 60 * 1000) {
            return false;
        }

        return true;
    }

    @SuppressLint("NewApi")
    private void showRateDialog() {
        if (activity == null || activity.isFinishing()) return;

        AlertDialog.Builder builder = new AlertDialog.Builder(activity);

        builder.setTitle(DIALOG_TITLE);
        builder.setMessage(DIALOG_MESSAGE);

        builder.setPositiveButton(BUTTON_RATE_NOW, (dialog, which) -> {
            rateApp();
            getPrefs().edit().putBoolean(KEY_DONT_SHOW_AGAIN, true).apply();
        });

        builder.setNeutralButton(BUTTON_REMIND_LATER, (dialog, which) -> {
            getPrefs().edit().putLong(KEY_REMIND_LATER_DATE, System.currentTimeMillis()).apply();
        });

        builder.setNegativeButton(BUTTON_NO_THANKS, (dialog, which) -> {
            getPrefs().edit().putBoolean(KEY_DONT_SHOW_AGAIN, true).apply();
        });

        builder.create().show();
    }

    private void rateApp() {
        final String appPackageName = activity.getPackageName();
        try {
            activity.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("market://details?id=" + appPackageName)));
        } catch (android.content.ActivityNotFoundException anfe) {
            activity.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("https://play.google.com/store/apps/details?id=" + appPackageName)));
        }
    }

    // --- Standard Plugin Interface Methods ---
    @Override public String getPluginName() { return "RatingPlugin"; }
    @Override public void onActivityResult(int requestCode, int resultCode, Intent data) {}
    @Override public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {}
    @Override public boolean shouldOverrideUrlLoading(WebView view, String url) { return false; }
    @Override public void onPageStarted(String url) {}
    @Override public void onPageFinished(String url) {}
    @Override public void onResume() {}
    @Override public void onPause() {}
    @Override public void onDestroy() {}
    @Override public void evaluateJavascript(String script) {}
}

Also, you can safely remove these reference strings previously used by rating plugin (which are now hardcoded).
res/values/strings.xml

    <string name="rate_dialog_title">Rate</string>
    <string name="rate_dialog_message">If you like our app, would you mind taking a moment to rate it? It won\'t take more than a minute. Thanks!</string>
    <string name="rate_dialog_ok">RATE</string>
    <string name="rate_dialog_cancel">LATER</string>
    <string name="rate_dialog_no">DON\'T ASK AGAIN</string>

Note: Don't forget to clean and rebuild the project. As for new android studio: Build > Clean and Assemble Project with Tests.

I'm going to add these changes to the next release. Meanwhile you can just make these changes in your project and test it, there still can be a chance that some other older migrated libraries/scripts/plugins come up with the same issue, which can be fixed the same way.

[ruturajpatki]

Thanks so much for your response. I will replace the code and will test it.

Just a suggestion... I think it's better to keep two separate branches in repo... dev and main. keep pushing your experimental code to dev and when you're ready, just pull the final changes from dev to main or simply push the stable version of your code to main branch. This way, users will know which one is stable version and which one is nightly build.

I will test your code and will get back to you with the results later for sure. Once again, thanks for your help and continued support. Per my personal experience, it's rare to find such active support on Github.

[mgks]

I hope this solution works well for you. As for handling multiple branches, I can definitely give it a try. 👍🏼

P.S. 😄 Plugging myself here again. If you’d like to fund my caffeine addiction, you can become a patron. ☕