Skip to content

Conversation

@simanga-dev
Copy link

update read me

@mgierada
Copy link
Owner

mgierada commented Dec 24, 2024

Thanks @simanga-dev for the contribution!

As for now, the toggle function is not exposed publicly so one cannot define config the way you did this. This functionality is missing, thought it doesn't look like a complex nor time consuming thing to do. Feel free to update your PR.

On the other hand I don't see much value having toggle method. You can easily dismiss the floating terminal with q. Could you please elaborate more what is your use case? I might end up prioritizing the feature knowing that it makes sense to implement it.

@mgierada mgierada added the help wanted Extra attention is needed label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants