Skip to content

Support guzzlehttp/psr7 2+, remove support for guzzlehttp/psr7 < 1.7 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented Jul 1, 2021

This change replaces a deprecated function from guzzlehttp/psr7. It was deprecated in guzzlehttp/psr7 1.7.0 and removed in guzzlehttp/psr7 2.0.

Currently, php-graphql-client does not block guzzlehttp/psr7 2.0, so installations using php-graphql-client will crash when guzzlehttp/psr7 is updated to the latest version.

@db306
Copy link

db306 commented Jul 10, 2021

Up ? @mghoneimy is it ok to move forward and merge this PR ?

@mghoneimy mghoneimy merged commit 41fc5e0 into mghoneimy:master Jul 18, 2021
@mghoneimy
Copy link
Owner

All looks good, merging now.

Thanks @jorrit !

@tm1000
Copy link

tm1000 commented Jul 19, 2021

@mghoneimy can we get this published? 1.11?

@mghoneimy
Copy link
Owner

I was hoping to push another change along with this to 1.11, but I can expedite this and push this now as the change looks highly anticipated.

Done:
https://github.com/mghoneimy/php-graphql-client/releases/tag/v1.11

@tm1000
Copy link

tm1000 commented Jul 21, 2021

Thanks @mghoneimy much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants